Add duplicates check in Sync Triggers #11371
Open
+130
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds duplicate function metadata detection and handling to the Sync Triggers functionality, ensuring only the first occurrence of duplicate function names is processed.
Key changes:
- Implements deduplication logic in the sync triggers payload generation
- Adds comprehensive test coverage for the duplicate handling behavior
- Removes unused import from FunctionMetadataExtensions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/WebJobs.Script.WebHost/Management/FunctionsSyncManager.cs |
Adds GroupBy logic to deduplicate function metadata by name, keeping first occurrence |
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs |
Adds test case to verify deduplication behavior with comprehensive setup and assertions |
src/WebJobs.Script.WebHost/Extensions/FunctionMetadataExtensions.cs |
Removes unused Microsoft.Azure.WebJobs.Logging import |
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Outdated
Show resolved
Hide resolved
test/WebJobs.Script.Tests.Integration/Management/FunctionsSyncManagerTests.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Sep 26, 2025
mathewc
reviewed
Sep 26, 2025
satvu
commented
Sep 26, 2025
kshyju
reviewed
Sep 29, 2025
mathewc
reviewed
Oct 1, 2025
liliankasem
reviewed
Oct 6, 2025
liliankasem
approved these changes
Oct 6, 2025
soninaren
approved these changes
Oct 6, 2025
|
@microsoft-github-policy-service rerun |
2 similar comments
|
@microsoft-github-policy-service rerun |
|
@microsoft-github-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #11284
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md